Repository navigation
Fixed build, added support for negative indexes in Robot keywords - #317
Merged
Merged
Conversation
eweitz
referenced
this pull request
in HelioGuilherme66/robotframework-seleniumlibrary
Aug 22, 2014
Set tag Regression to non-critical in travis.yml. Utility shell script to rename *.txt to *.robot.
Contributor
Contributor
Author
|
@ombre42, glad to help. Is there anything preventing this from being merged into rtomac:master? |
emanlove
added a commit
that referenced
this pull request
Aug 27, 2014
Fixed build, applied fix for 'Choose File' bug, from Hélio Guilherme, and added support for negative indexes in Robot keywords
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the rtomac:master build and adds support for negative indexes in Robot keywords.
Fixed Se2Lib build
@emanlove, this fixes the build failure currently noted at https://github.com/rtomac/robotframework-selenium2library.
Passing Travis CI build:
The 14 critical test failures reported in the current rtomac:master build (https://travis-ci.org/rtomac/robotframework-selenium2library/jobs/23423255) are caused by unexpected content in test/results/output.xml. An extra line was added in the log output of a frequently-used command -- likely due to an update in the upstream Selenium 2 package.
The failing Se2Lib tests simply needed to account for the fact that the expected log file content is now a few lines ahead of where it was previously.
I also applied a fix for the 'Choose File' bug by @HelioGuilherme66 (from 532295c).
Support for negative indexes in Robot keywords
Robot keywords like
Table Row Should Containsupport looking up elements with a positional, 1-based index, e.g.verifies that the first row (row 1) in the table with the ID defined in 'table_locator' has the expected content defined in 'expected_first_row'.
Unfortunately,
Table Row Should Containdoes not currently support easily looking up content from the end of a table. For example, it would be very helpful to be able to write something liketo verify the content of the last row (row -1) in a table. Row -2 would be the second-to-last row, and so on -- just like negative indexes in Python lists.
This pull request adds support for negative indexes to the following Robot keywords:
Table Row Should ContainTable Column Should ContainTable Cell Should Contain